Unify renderer names across platforms

AdrianKnightAdrianKnight USMember ✭✭✭✭

Summary

Default renderer names are not consistent across platforms. Why? Inconsistency is a problem from a semantic point of view, but also this seems to increase startup time when we're registering handlers. See this line.

API Changes

  • Remove internal renderer types starting with _ as in the case of _NavigationPageRenderer
  • Provide consistent naming for renderers like so: [ElementName]Renderer
  • Implementation detail: Remove attribute2 lookup in Registrar so that we shave off 5-15 ms (on S6 at least) for each iteration

Intended use case

Since people are complaining about Android startup performance, this should help us reduce startup times. It will also not confuse us with inconsistent naming patterns.

Tagged:

Open · Last Updated

Posts

  • rmarinhormarinho PTMember, Insider, Beta Xamurai

    Yeah we had this on the list , i m not sure if this would be a breaking change or not..

  • MichaelRumplerMichaelRumpler ATMember ✭✭✭✭✭
    • Rename the renderer
    • create a new one which inherits from the old and has the old name
    • immediately obsolete the renderer with the old name with a message which indicates the correct name

    => People will get warnings if they use the wrong name, but everything still works. No breaking change!

Sign In or Register to comment.